Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application: Refactoring #25

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Application: Refactoring #25

wants to merge 8 commits into from

Conversation

ryonakano
Copy link
Contributor

@ryonakano ryonakano commented Dec 14, 2024 •
edited
Loading

  • Rename variable has_object to has_adapter for readability
    • This flag holds whether there is a Bluetooth adapter connected to your device
  • Require files for --send option
    • Files specified in the command-line argument are only used for this option, so lets make these files designated for this option
  • Split parsing files passed as arguments and sending them into methods
  • Treat errors first and use shorten and generalized word for log message
  • Use GLib.Application.add_main_option_entries() instead of parsing options manually
    • This also prevents the app launched when passing invalid options
  • Coding style: Fix missing space ()=>{→() => {

@ryonakano ryonakano force-pushed the ryonakano/application-refactor branch from 2b90d28 to f7fa76c Compare December 14, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ryonakano